docs: use Libp2p.create() in examples (#811)#814
Merged
vasco-santos merged 2 commits intolibp2p:masterfrom Nov 30, 2020
a1300:docs_libp2p_create_example
Merged
docs: use Libp2p.create() in examples (#811)#814vasco-santos merged 2 commits intolibp2p:masterfrom a1300:docs_libp2p_create_example
vasco-santos merged 2 commits intolibp2p:masterfrom
a1300:docs_libp2p_create_example
Conversation
vasco-santos
suggested changes
Nov 27, 2020
Member
vasco-santos
left a comment
vasco-santos
left a comment
There was a problem hiding this comment.
Thanks for the PR. Except for my two comments in the API doc, everything looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't changed the use of
new Libp2p()in theexamples/delegated-routingdirectory because this is already in progress in PR #507js-libp2p/examples/delegated-routing/src/libp2p-bundle.js
Lines 23 to 30 in d0a9fad